pocket-casts-android icon indicating copy to clipboard operation
pocket-casts-android copied to clipboard

Migrate share fragment to Jetpack Compose

Open CalebKL opened this issue 2 years ago • 2 comments

Description

This PR migrates the share Fragment views to Jetpack Compose. The Compose version is the exact replica from the views. In case of any padding values I missed, I would be glad to counter check Fixes #

Testing Instructions

Screenshots or Screencast

Checklist

  • [ ] If this is a user-facing change, I have added an entry in CHANGELOG.md
  • [ ] I have considered whether it makes sense to add tests for my changes
  • [ ] All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • [X] Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • [ ] with different themes
  • [ ] with a landscape orientation
  • [ ] with the device set to have a large display and font size
  • [ ] for accessibility with TalkBack

CalebKL avatar Jul 20 '23 06:07 CalebKL

👋 @Mzazi25 ! Are you still planning to work on this?

mchowning avatar Oct 18 '23 18:10 mchowning

👋 @Mzazi25 ! Are you still planning to work on this?

Since we decided to use the option dialog, the only blocker we had is we have to work on the optionDialog configuration first. When we change the configuration, the dialog doesn't update the state as expected.

CalebKL avatar Oct 18 '23 18:10 CalebKL