Admin Page: need to click twice to remove searchform

[jeherve]

Steps to reproduce the issue

1. Go to Jetpack > Settings.
2. Click on the search icon.
3. Launch a search. Find what you're looking for, make changes.
4. Click on the X icon to remove the searchform.
5. Where are the tabs I'd like to use to navigate to different settings? They're still hidden, I need to click once more on X to fully remove the searchform.

[zinigor]

@eliorivero had a good idea to fix that problem by introducing a different icon for the close button. Because once you have filled the search bar it acts as a clear button, not as a close button. Do yout think it would be a more appropriate solution?

[eliorivero]

I voiced my concerns about this when this was being implemented:

https://github.com/Automattic/jetpack/pull/6424#pullrequestreview-25359217

I like that the second click in the x exits the search mode. Maybe the first one should be a different symbol? One that indicates that clicking it will erase the field?

It feels broken having to click twice to close the field and without any change after the first click. It must be addressed using for example the ⌫ icon or something similar that indicates that the input field will be cleared. If we don't have the icon, maybe even the Clear word nicely composed will be enough.

[stale[bot]]

This issue has been marked as stale. This happened because:

• It has been inactive in the past 6 months.
• It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.