jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

A4A Client: defer connection check to plugins_loaded hook

Open vitozev opened this issue 2 months ago • 2 comments

Fixes #

Proposed changes:

Problem

The A4A Client plugin experiences fatal errors on Atomic sites because $manager->is_connected() runs too early in init(), before WordPress core functions like get_user_by() are available. This was introduced in PR #37337.

Solution

Move the connection check from init() to the plugins_loaded hook (priority 20) so:

  • WordPress core functions are available
  • Connection package is initialized first (priority 1)
  • Deactivation handler still initializes early enough

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Spin up a JN site with the A4A client plugin installed on top of this branch (e.g., /wp-admin/admin.php?page=jetpack-beta&plugin=automattic-for-agencies-client)
  • With a disconnected site, deactivate the plugin. Verify no interstitial connection pop-up is shown and the plugin deactivates right away.
  • Re-activate the plugin, and connect the site.
  • Deactivate the plugin, verify the disconnect dialog pops up before deactivating the plugin.

vitozev avatar Nov 24 '25 13:11 vitozev

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Review, ...).
  • :red_circle: Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Automattic For agencies client plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Nov 24 '25 13:11 github-actions[bot]

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/automattic-for-agencies-client/src/class-automattic-for-agencies-client.php 0/57 (0.00%) 0.00% 1 ❤️‍🩹

Full summary · PHP report · JS report

jp-launch-control[bot] avatar Nov 24 '25 13:11 jp-launch-control[bot]