jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Add PayPal Payments plugin

Open allie500 opened this issue 7 months ago • 3 comments

Fixes #PAYPAL-17

Proposed changes:

  • This PR adds a new plugin that allows usage of the PayPal Payments package payments button block. This plugin will allow self-hosted sites that don't have Jetpack installed to use the PayPal payments block.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pcqRLn-2xw-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • TBD

allie500 avatar Jun 18 '25 18:06 allie500

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/paypal-payments-plugin branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/paypal-payments-plugin
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/paypal-payments-plugin

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Jun 18 '25 18:06 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Review, ...).
  • :red_circle: Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Paypal Payments plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Jun 18 '25 18:06 github-actions[bot]

Code Coverage Summary

Cannot generate coverage summary while tests are failing. :zipper_mouth_face:

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

jp-launch-control[bot] avatar Jun 18 '25 18:06 jp-launch-control[bot]

I've been looking into the block not getting registered issue, and I think it's just due to the editor script not being found. As we're loading it from Jetpack, the file isn't part of the plugin.

So I assume we will need to copy the dist folder of the block as part of the build process, or something similar.

ismaeldcom avatar Jun 27 '25 15:06 ismaeldcom

Closing in favor of https://github.com/Automattic/jetpack/pull/44479

ebinnion avatar Jul 26 '25 02:07 ebinnion