Forms: improves the validation error animation

[enejb]

Before:

https://github.com/user-attachments/assets/1d1a45f3-d2e7-4972-bd5c-d7b485bbb661

After:

https://github.com/user-attachments/assets/6f2f2345-1307-4b9b-abad-f9445d0fcbbf

Improved the animation

Proposed changes:

• Animate the error message by changing the max-height.
• Add a fixed height to the warning triangle so that it moved as expected.

Other information:

• [ ] Have you written new tests for your changes, if applicable?
• [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
• [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1HpG7-wPD-p2

Does this pull request change what data or activity we track or use?

no

Testing instructions:

Add a form that has an email field. On the front end you should notice that the field's error message now animates differetntly.

[github-actions[bot]]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-validation-animation branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/forms-validation-animation

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions[bot]]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• :white_check_mark: Include a description of your PR changes.
  
• :white_check_mark: Add a "[Status]" label (In Progress, Needs Review, ...).
  
• :white_check_mark: Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• :white_check_mark: Add testing instructions.
  
• :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  
• :white_check_mark: Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly:
  • Scheduled release: July 1, 2025
  • Code freeze: June 30, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control[bot]]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[simison]

@edanzer it's the right kind of nit-picky, thanks! :-)

[enejb]

Thanks for the feedback @edanzer. Any sort of feedback is always welcome :) The challenge with this change change is that I can't position the svg using center alignment any more because it causes even more strange issues.

I think the best approach here would be to just use px value error message and the vertical position of the icon. I think this would make it work out well.

One of the current issues is that in some themes the font size of the error is way to small. See. I think in those cases we might have to use a css clamp in order to fix it.

[ilonagl]

😍😍😍

[enejb]

@edanzer I am keeping the position of the icon the same. now that I am only animating the tranform (Y) and not the height the icon doesn't jump.

@ilonagl and @ederrengifo can you take another look?

The screencast in the PR description has been updated.

[ilonagl]

Ship it!! 🚀 😍 and if @ederrengifo has any thoughts, we can tackle them in a following PR. wdyt?