Automattic
Fix ThreatDataView popover content
Fixes # The content in the IconToolTip popover is not properly styled.
Proposed changes:
- Add CSS to apply changes
Other information:
- [ ] Have you written new tests for your changes, if applicable?
- [x] Have you checked the E2E test CI results, and verified that your changes do not break them?
- [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?
Jetpack product discussion
- https://github.com/Automattic/jetpack-scan-team/issues/1471
Does this pull request change what data or activity we track or use?
- No
Testing instructions:
- Checkout this branch
- Load storybook with
cd projects/js-packages/storybook && npm run storybook:dev - View the Threats Data View component and hover over the red info icon
- Ensure the content is position and styled appropriately
Screenshot
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
- :white_check_mark: Include a description of your PR changes.
- :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
- :white_check_mark: Add testing instructions.
- :white_check_mark: Specify whether this PR includes any changes to data or privacy.
- :red_circle: Add changelog entries to affected projects
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
:red_circle: Action required: Please add missing changelog entries for the following projects: projects/js-packages/components
Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md
Follow this PR Review Process:
- Ensure all required checks appearing at the bottom of this PR are passing.
- Choose a review path based on your changes:
-
A. Team Review: add the "[Status] Needs Team Review" label
- For most changes, including minor cross-team impacts.
- Example: Updating a team-specific component or a small change to a shared library.
-
B. Crew Review: add the "[Status] Needs Review" label
- For significant changes to core functionality.
- Example: Major updates to a shared library or complex features.
-
C. Both: Start with Team, then request Crew
- For complex changes or when you need extra confidence.
- Example: Refactor affecting multiple systems.
-
A. Team Review: add the "[Status] Needs Team Review" label
- Get at least one approval before merging.
Still unsure? Reach out in #jetpack-developers for guidance!
Protect plugin:
- Next scheduled release: none scheduled.
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.