Protect: Fix ScanHistoryDetails fixedOn property
Fixes
There is mismatching fixedAt property passed in the usage of the ScanHistoryDetails component in the PaidAccordion. Because of this, undefined is passed and we display todays date.
Proposed changes:
- Update the property to
fixedOn - Rename properties for better clarity
Other information:
- [ ] Have you written new tests for your changes, if applicable?
- [x] Have you checked the E2E test CI results, and verified that your changes do not break them?
- [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?
Jetpack product discussion
- https://github.com/Automattic/jpop-issues/issues/9202
Does this pull request change what data or activity we track or use?
- No
Testing instructions:
- View a site w/ the latest Protect version, a scan upgrade, and historical fixed threats
- Verify that the
Threat fixeddate in the history details is today's date - Install the Jetpack Beta Tester plugin and upgrade Protect to this branch
- Reload the History and ensure that the date rendered is correct, and corresponds with the results in Calyspo
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
- :white_check_mark: Include a description of your PR changes.
- :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
- :white_check_mark: Add testing instructions.
- :white_check_mark: Specify whether this PR includes any changes to data or privacy.
- :white_check_mark: Add changelog entries to affected projects
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Follow this PR Review Process:
- Ensure all required checks appearing at the bottom of this PR are passing.
- Choose a review path based on your changes:
-
A. Team Review: add the "[Status] Needs Team Review" label
- For most changes, including minor cross-team impacts.
- Example: Updating a team-specific component or a small change to a shared library.
-
B. Crew Review: add the "[Status] Needs Review" label
- For significant changes to core functionality.
- Example: Major updates to a shared library or complex features.
-
C. Both: Start with Team, then request Crew
- For complex changes or when you need extra confidence.
- Example: Refactor affecting multiple systems.
-
A. Team Review: add the "[Status] Needs Team Review" label
- Get at least one approval before merging.
Still unsure? Reach out in #jetpack-developers for guidance!
Protect plugin:
- Next scheduled release: none scheduled.
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.