jetpack Point "Edit Profile" to /me when the user is not a member of the site

Related to

https://github.com/Automattic/dotcom-forge/issues/8697
https://github.com/Automattic/wp-calypso/pull/93938

Proposed changes:

This PR points "Edit Profile" and "Howdy,.." to /me when the user is not a member of the site

This PR complements the implementation of Calypso: https://github.com/Automattic/wp-calypso/pull/93938.

Other information:

[x] Have you written new tests for your changes, if applicable?
[x] Have you checked the E2E test CI results, and verified that your changes do not break them?
[x] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Follow the instructions in https://github.com/Automattic/wp-calypso/pull/93938

Aug 27 '24 08:08 okmttdhr

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/site-level-user-profile-entry-point branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/site-level-user-profile-entry-point

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Aug 27 '24 08:08 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

:white_check_mark: Include a description of your PR changes.
:white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
:white_check_mark: Add testing instructions.
:white_check_mark: Specify whether this PR includes any changes to data or privacy.
:white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Mu Wpcom plugin:

Next scheduled release: WordPress.com Simple releases happen daily.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Aug 27 '24 08:08 github-actions[bot]

The code looks good to me but I'm confused about how to test it as

On simple default, it has pointed to /me, and /me/accountalready if the user is not a member of the site
On atomic default, there is no profile edit menu if the user is not a member of the site

Am I missing something 🤔

Aug 30 '24 06:08 arthur791004

The code looks good to me but I'm confused about how to test it as

On simple default, it has pointed to /me, and /me/accountalready if the user is not a member of the site

On atomic default, there is no profile edit menu if the user is not a member of the site

This PR brings a change opposite to what the title suggests; We’re updating the behavior so that profile.php is shown, regardless of the Admin Interface Style, when wpcom_site_level_user_profile=1 is set and the user is a member of the site. Before this PR, if Default Site points to /me even if the user is a member of the site.

So, you should be able to test this PR on a Default Site with wpcom_site_level_user_profile=1 by using a user who is a member of the site. In this case, it should change to show profile.php. Does it make sense? @arthur791004

Aug 30 '24 06:08 okmttdhr

So, you should be able to test this PR on a Default Site with wpcom_site_level_user_profile=1 by using a user who is a member of the site. In this case, it should change to show profile.php. Does it make sense

Followed the instructions above, and it works as expected

If the user is a member of the site and the site disabled wpcom_site_level_user_profile, "Edit Profile" and "Howdy,.." points to /me and /me/account respectively
If the site enabled wpcom_site_level_user_profile, both of "Edit Profile" and "Howdy,.." points to profile.php as described above!

Aug 30 '24 13:08 arthur791004