jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Licensing: Add conditional Protect redirect post Scan license activation

Open dkmyta opened this issue 1 year ago • 3 comments

Description

After a Scan license is activated in My Jetpack, the ActivationScreenSuccessInfo component displays a link to View scan results in Jetpack Cloud. As part of the standalone first initiative, when we detect that Jetpack Protect is active, we should always direct users to the Protect UI to view these results.

Proposed changes:

  • Rearranges the current links
  • Adds conditional logic to update the View scan results redirect to Cloud or Protect when applicable

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [x] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • https://github.com/Automattic/jetpack-scan-team/issues/1365

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Create a new JN instance using the beta tester with Jetpack installed using this branch
  • Purchase a Scan license from jetpack.com but don't yet assign it to a site
  • Refer to Store Admin for your user and locate the license key
  • Proceed to the JN site and to /wp-admin/admin.php?page=my-jetpack#/add-license
  • Enter key and select activate, from the post activation screen verify that the UI display as in the provided screenshot
  • Ensure that the View scan results link redirects to Scan's Cloud dashboard and that the View my plans link performs as expected
  • Perform the same steps once again but this time after first installing and activating Protect
  • Verify that the View scan results link now redirect to /wp-admin/admin.php?page=jetpack-protect#/scan
  • Ensure no regressions are introduced and that other license activations are unaffected by the changes

Screenshot

Screen Shot on 2024-08-21 at 14-29-40

dkmyta avatar Aug 21 '24 22:08 dkmyta

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/licensing-protect-redirect branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/licensing-protect-redirect
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Aug 21 '24 22:08 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

github-actions[bot] avatar Aug 21 '24 22:08 github-actions[bot]

Would also be ideal if we could update the copy:

"You can see your security scans on cloud.jetpack.com"

nateweller avatar Aug 29 '24 23:08 nateweller