jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

WPCOMSH: Removing duplicated functionality to remove masterbar module listing

Open coder-karen opened this issue 1 year ago • 1 comments

On hold

This now may need to wait until the module itself is removed as it seems there may be a priority issue - the module is not disappearing from the modules page using this PR.

Fixes https://github.com/Automattic/vulcan/issues/448

Proposed changes:

  • Once this PR was merged - https://github.com/Automattic/jetpack/pull/38804 - the 'masterbar' module no longer showed up on the Jetpack modules page. As such the function in wpcomsh/masterbar.php to do the same is not needed, and is removed in this PR.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/vulcan/issues/448

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • To test this out, the best option may be to use rsync on a WoA dev site: jetpack rsync wpcomsh - the path being /srv/htdocs/wp-content/plugins/wpcomsh-dev
  • You may be able to use a WoA test site using the Beta tester plugin and checking out this branch but I was unable to change branches or even change to bleeding edge / RC on wpcomsh using the Beta Tester plugin
  • Visit the modules page - wp-admin/admin.php?page=jetpack_modules - and you should not see any listing for the WordPress.com Toolbar (this is the 'masterbar' module).

coder-karen avatar Aug 14 '24 09:08 coder-karen

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Aug 14 '24 09:08 github-actions[bot]

Closing this as unneeded just now.

coder-karen avatar Sep 03 '24 14:09 coder-karen