jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Classic Theme Helper Plugin: Ensure Featured Content and imported / required files in the package are initialized

Open coder-karen opened this issue 1 year ago • 1 comments

Fixes https://github.com/Automattic/vulcan/issues/384

Proposed changes:

  • This PR ensures the classes that initialize both Featured Content and Responsive Videos from the Classic Theme Helper package are initialized in the plugin, so they can work even if Jetpack is not also initializing those classes.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/vulcan/issues/384

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

To replicate the issue with this plugin not initializing Responsive Videos and Featured Content:

  • Testing locally, make sure you have installed and built the Classic Helper Theme plugin: jetpack install plugins/classic-theme-helper-plugin, jetpack build plugins/classic-theme-helper-plugin, then activate the plugin.
  • Comment out responsive-videos and featured-content from projects/plugins/jetpack/modules/module-extras.php Rebuild the Jetpack plugin - jetpack build plugins/jetpack)
  • Follow the steps in this PR to test Responsive Videos and Featured Content (only on self-hosted): https://github.com/Automattic/jetpack/pull/37969
  • They shouldn't work.

To test the fix:

  • Apply this PR and follow the same steps as above.
  • Responsive Videos and Featured Content should work as expected.

coder-karen avatar Jul 02 '24 16:07 coder-karen

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Classic Theme helper plugin plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Jul 02 '24 16:07 github-actions[bot]