jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

Classic Theme Helper: Featured content remove wpcom only code

Open darssen opened this issue 1 year ago • 2 comments

Related to https://github.com/Automattic/vulcan/issues/348

Proposed changes:

As explained in https://github.com/Automattic/jetpack/pull/37260#discussion_r1592423312. The hooks for featured content that only pertains to simple should be moved to the featured-content mu-plugin in wpcom.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pfwV0U-6Y-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Copying the amazing instructions provided in https://github.com/Automattic/jetpack/pull/37969 by @coder-karen Self-hosted / Atomic / Simple:

To test existing behaviour:

  • With a theme that supports Featured Content (Dara is an example), open the Customizer. You should see a 'Featured Content' section. When opening the page source from here, you should see the featured-content-suggest-js (and that it's source on Atomic is from the jetpack-mu-wpcom-plugin plugin (or jetpack-mu-wpcom-plugin-dev if using the beta tester plugin), or jetpack / jetpack-dev on self-hosted sites ).
  • Confirm everything works as it should: Add a tag and click save, then apply that tag to a few posts - the featured content should display on the homepage.

To test this PR:

  • For responsive videos, follow the steps above, then view the post / page source for the published post / page. Notice the jetpack-responsive-videos-js script in the page source (and that it's source is from the jetpack-mu-wpcom-plugin on Atomic and jetpack on self-hosted sites ) , and that the video is wrapped in a div with the class jetpack-video-wrapper.
  • For the Featured Content changes in this PR, follow the same testing steps as when testing existing behaviour.
  • Everything should test as it did before (and the featured-content-suggest-js script source is the same as before as well).

darssen avatar Jul 02 '24 13:07 darssen

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/featured-content-remove-wpcom-only-code branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/featured-content-remove-wpcom-only-code

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/featured-content-remove-wpcom-only-code

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Jul 02 '24 13:07 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Mu Wpcom plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Classic Theme helper plugin plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Jul 02 '24 13:07 github-actions[bot]