jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

Show classic admin interface profile settings notice

Open xavier-lc opened this issue 1 year ago • 2 comments

Fixes https://github.com/Automattic/dotcom-forge/issues/7877

Proposed changes:

This PR adds a banner that helps explain that updates made on /wp-admin/profile.php only sync to sites with the Classic admin-interface style. Classic admin-interface sites are "untangled" from /me and /me/account and do not sync.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Apply this patch to your sandbox
  2. Test this on a site that uses the "Classic" admin interface
  3. Go to /wp-admin/profile.php, check that you see this banner:

image

  1. Check that the link goes to https://wordpress.com/support/dashboard/#set-the-admin-interface-style

xavier-lc avatar Jul 01 '24 09:07 xavier-lc

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/show_classic_admin_interface_profile_settings_notice branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/show_classic_admin_interface_profile_settings_notice

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Jul 01 '24 09:07 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Mu Wpcom plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Jul 01 '24 09:07 github-actions[bot]

Thank you @xavier-lc.

The goal of this banner is two-fold:

  • Make it clear to users that they are only editing their profile settings for that specific site.
  • Provide a direct link to their global dotcom account profile.

I do not think the current text helps with either of those two things. How about we try this instead:

The profile settings below only apply to {Site URL}. To edit your global setting, visit your [WordPress.com profile](https://wordpress.com/me).

Let me ping @taipeicoder and @okmttdhr for a gut check.

mrfoxtalbot avatar Jul 03 '24 08:07 mrfoxtalbot

Thanks @xavier-lc. However, we're pursing a new approach (https://github.com/Automattic/dotcom-forge/issues/8421), so we will need to close this PR. 🙏

fushar avatar Jul 23 '24 08:07 fushar