jetpack Plugin menu consistency

Fixes: https://github.com/Automattic/dotcom-forge/issues/6940, see also pfsHM7-YW-p2

Proposed changes:

Plugins menu for untangled sites

All sites should now get these plugin menu items:

Installed plugins (plugins.php)
Add New Plugin (plugin-install.php)
Plugin Marketplace (wordpress.com/plugins/:site)

Additionally, atomic sites also get "Scheduled Updates" (wordpress.com/plugins/scheduled-updates/:site).

This means that sites have consistency across simple and WoA environments, and the plugin marketplace is accessible.

Other information:

[ ] Have you written new tests for your changes, if applicable?
[ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
[ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Apply to sandbox
Sandbox an untangled simple site
Go to /wp-admin on the simple site
Use the plugin menu
Note that the marketplace menu will take you to Calypso, examine the plugin menu again, it should be consistent.
Apply to an untangled atomic site, and do the same checks.

May 23 '24 19:05 dsas

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/plugin-menu2 branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/plugin-menu2

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

May 23 '24 19:05 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

:white_check_mark: Include a description of your PR changes.
:white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
:white_check_mark: Add testing instructions.
:white_check_mark: Specify whether this PR includes any changes to data or privacy.
:white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

May 23 '24 19:05 github-actions[bot]

Tests / Static analysis (pull_request) Failing after 4m

Updated the stubs in D150355-code but they are not updated in Jetpack. Asked in p1716983860931499-slack-CDLH4C1UZ

EDIT: Solved

May 29 '24 12:05 mmtr