jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Social: Add connection management tests

Open gmjuhasz opened this issue 1 year ago • 2 comments

Fixes https://github.com/Automattic/jetpack-reach/issues/360

Proposed changes:

  • Adds unit tests for components
  • Adds some general integration test for the connection list

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-reach/issues/360

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Go to the publicize components folder projects/js-packages/publicize-components

  • Run tests with pnpm run test

    ConnectionStatus ✓ renders nothing when connection status is "ok" (19 ms) ✓ renders nothing when connection status is undefined (2 ms) ✓ renders the appropriate notice and Reconnect component when connection status is not "ok" or undefined (4 ms) ✓ renders the correct notice when connection status is "refresh-failed" (2 ms)

    Reconnect ✓ renders the Reconnect button with correct label (35 ms) ✓ disables the button when isDisconnecting is true (9 ms) ✓ calls deleteConnectionById and requestAccess on button click (23 ms) ✓ does not render the button if connection cannot be disconnected (2 ms)

    Marking a connection as shared ✓ toggling the checkbox should mark a connection as shared (135 ms) ✓ toggle is disabled while updating (8 ms)

    Disconnecting a connection ✓ disconnecting a connection should call the disconnect method (200 ms) ✓ panel is disabled while updating (11 ms) ✓ button changes name and is disabled while updating (8 ms)

    ConnectionManagement No connections ✓ renders the component with no connections (43 ms) With connections ✓ renders the spinner without connection name (36 ms) ✓ renders the component with proper connections (13 ms) Connection panel ✓ connection panel can be opened and closed (111 ms) ✓ clicking disconnect should bring up confirmation which can be cancelled (96 ms) ✓ mark as shared component is visible if user has permission (43 ms)

gmjuhasz avatar May 23 '24 16:05 gmjuhasz

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/social-connection-management-tests branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/social-connection-management-tests
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar May 23 '24 16:05 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

github-actions[bot] avatar May 23 '24 16:05 github-actions[bot]