jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Super Cache: add form to confirm deleting Boost advanced-cache.php

Open donnchawp opened this issue 1 year ago • 2 comments

If the advanced-cache.php created by Jetpack Boost is found, the plugin displays a warning message saying that Boost must be deactivated before WP Super Cache can be used. This PR changes that message to a confirmation form that deletes the advanced-cache.php so that caching can be done by this plugin. Boost does not have to be deactivated.

ref: https://github.com/Automattic/jetpack/issues/37227

Proposed changes:

  • add a new file inc/boost.php to hold Boost related functionality.
  • The form, the code that handles submitting the form, and deleting the advanced-cache.php is in this file.
  • Load that form from wp-cache.php
  • Replace the original warning message with the form.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pc9hqz-2QH-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply this PR using the beta plugin
  • Activate Jetpack Boost and enable the Cache module.
  • From the Plugins page, activate WP Super Cache.
  • Go to the WP Super Cache settings page and note the new confirmation form that says Boost was found.
  • Submit that form and the page will reload into the "Easy" settings page of the plugin.
  • Visit the Boost settings page. The Cache module will be disabled but show a warning about the advanced-cache.php

Before: Screenshot 2024-05-09 at 13 43 42

After: Screenshot 2024-05-09 at 14 07 54

donnchawp avatar May 07 '24 15:05 donnchawp

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Super Cache plugin:

  • Next scheduled release: June 4, 2024.
  • Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar May 07 '24 15:05 github-actions[bot]

p1716371347024369-slack-C016BBAFHHS

haqadn avatar May 22 '24 09:05 haqadn