Boost: Add switch to Boost Cache
Related to Automattic/boost-cloud#439
ref: #37227
Proposed changes:
- Move page_cache module to it's own react component extracted from
index.tsx. - Refactor page-cache error notices, use react components for each error type.
- If advanced-cache.php file is present and belongs to super-cache:
- Silently deactivate super-cache and enable boost cache if super-cache config is compatible with Boost.
- Present a "Switch to Boost" button (see screenshot below) if the config indicate more advanced usage.
Other information:
- [ ] Have you written new tests for your changes, if applicable?
- [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
- [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?
Jetpack product discussion
None
Does this pull request change what data or activity we track or use?
None
Testing instructions:
Super Cache config is compatible with Boost
- Enable and setup super cache with simple mode (might be a good idea to reset the config from advanced tab to get a fresh setup).
- Install Boost, try to activate Cache.
- You should now have Boost cache with super-cache deactivated.
Super Cache config is NOT compatible with Boost
- Now turn off Boost Cache, remove
wp-content/advanced-cache.php, and enable super cache again - In your WPSC settings change one of the advanced settings listed in pc9hqz-2Om-p2 #:~:text=Mobile%20device%20support,Tracking%20Parameters. e.g.: Don’t cache if GET parameters present
- Try to enable Boost Cache
- A button on the error notice should allow you to "Switch to Boost Cache"
- Clicking this should disable WPSC and activate the Cache module on Boost.
- Make sure caching is working.
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
- :white_check_mark: Include a description of your PR changes.
- :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
- :white_check_mark: Add testing instructions.
- :white_check_mark: Specify whether this PR includes any changes to data or privacy.
- :white_check_mark: Add changelog entries to affected projects
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.
Boost plugin:
- Next scheduled release: June 4, 2024.
- Scheduled code freeze: May 27, 2024.
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
Edit: after talking to Adnan, it is working as intended. If features are compatible with Boost, then enabling the cache module will deactivate WPSC so that only one caching plugin is active. If the features are not compatible, then activating the cache module will show the popup.
I have added a notice as we have discussed in slack.