jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Fix/table interstitial loading buttons

Open jboland88 opened this issue 1 year ago • 3 comments

Proposed changes:

This PR updates the table interstitial screens in My Jetpack so that only one button shows in a "loading" state after being clicked instead of both buttons showing the loading icon (which is what happens now)

I chose the first approach that came to mind - if you spot another solution that would be better, let me know!

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Get a test site w/ Jetpack Beta - don't apply this PR yet to see the original issue
  • Navigate to /wp-admin/admin.php?page=my-jetpack#/add-boost
  • Click on "Start for free"
  • Notice that both buttons show the loading spinner Screenshot 2024-03-26 at 5 24 07 PM
  • Now, with this PR applied, visit /wp-admin/admin.php?page=my-jetpack#/add-boost again
  • This time, when you click "Start for free", only the button you clicked on should show the loading spinner Screenshot 2024-03-26 at 5 29 39 PM

jboland88 avatar Mar 26 '24 21:03 jboland88

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/table-interstitial-loading-buttons branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/table-interstitial-loading-buttons
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Mar 26 '24 21:03 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :red_circle: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

github-actions[bot] avatar Mar 26 '24 21:03 github-actions[bot]

This PR has been marked as stale. This happened because:

  • It has been inactive for the past 3 months.
  • It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

github-actions[bot] avatar Jul 02 '24 00:07 github-actions[bot]

This PR has been automatically closed as it has not been updated in some time. If you want to resume work on the PR, feel free to restore the branch and reopen the PR.

github-actions[bot] avatar Aug 02 '24 00:08 github-actions[bot]