jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Update/migrate global notices to context

Open CodeyGuyDylan opened this issue 1 year ago • 2 comments

Proposed changes:

  • There was one instance left where the redux version of global notices was being used, this PR replaces that with the context version of notices
  • Remove notices from redux

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

P2: p1HpG7-rcF-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Checkout this branch via the Jetpack Beta plugin or your local dev environment
  2. Sandbox the ephemeral or jurassic.ninja site
  3. Purchase VideoPress for your site without connecting Jetpack to your user account
  4. Go to My Jetpack and create an only site Jetpack connection (You can do this by following the connection flow until it asks you to Approve the user connection, at that point go back to My Jetpack) image
  5. When you get to My Jetpack, make sure the connection warning notice shows up image
  6. Next, in WPCOM, go to this class: uggcf%3N%2S%2Suers.yv%2S%3Suggcf%3N%2S%2Sbcratebx.n8p.pbz%2Sfbhepr%2Skers%2Sjcpbz%2Schoyvp.ncv%2Serfg%2Sjcpbz%2Qwfba%2Qraqcbvagf%2Spynff.jcpbz%2Qfgber%2Qncv%2Qraqcbvagf.cuc%3Se%3Q1prs6727%23780-og and add return new WP_Error(); at the beginning of the callback function
  7. Make sure the purchases error still shows up as it should image

CodeyGuyDylan avatar Mar 05 '24 22:03 CodeyGuyDylan

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :red_circle: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

github-actions[bot] avatar Mar 05 '24 22:03 github-actions[bot]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/migrate-global-notices-to-context branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/migrate-global-notices-to-context
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Mar 05 '24 22:03 github-actions[bot]