jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

Nav redesign / jetpack mu - Unregister customizer items when on block theme.

Open Addison-Stavlo opened this issue 1 year ago • 3 comments

Fixes # https://github.com/Automattic/dotcom-forge/issues/5853

Proposed changes:

Removes the 'customize' menu and adminbar link from atomic sites on block themes running the nav redesign.

  • This is essentially a copy of @okmttdhr's work on https://github.com/Automattic/jetpack/pull/36017
  • The above linked fix is in the masterbar module, which is disabled as part of the new nav redesign.
  • This PR ports the same code to jetpack-mu-wpcom plugin, and applies them to atomic sites.

BEFORE

Screenshot 2024-03-04 at 2 13 10 PM Screenshot 2024-03-04 at 2 13 00 PM

AFTER

Screenshot 2024-03-04 at 2 12 26 PM Screenshot 2024-03-04 at 2 12 34 PM

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • On a WOA dev blog, enable the "Classic" interface setting under hosting->configuration settings.

  • Be proxied, or add the wpcom_classic_early_release site option to your site.

  • Ensure you have a block theme enabled.

  • Build and sync this branch of jetpack-mu-wpcom. PCYsg-Osp-p2

  • Verify the "Customizer" link no longer appears under:

    • "Appearance" in the wp-admin left nav menu
    • In the top adminbar while viewing the front end of the site.

  • visit the customizer directly by URL */wp-admin/customize.php, verify this loads as expected without errors.

  • Enable a classic theme and verify the customize menu reappears.

Addison-Stavlo avatar Mar 04 '24 19:03 Addison-Stavlo

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/customizer-removal-to-mu-wpcom branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/customizer-removal-to-mu-wpcom

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Mar 04 '24 19:03 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :red_circle: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

github-actions[bot] avatar Mar 04 '24 19:03 github-actions[bot]

This is ready for another look.

Addison-Stavlo avatar Mar 06 '24 13:03 Addison-Stavlo

WordPress.com Tests Failing after 3m — Failed! D140934-code

I reran this on the diff and it seems to be good now.

Addison-Stavlo avatar Mar 06 '24 18:03 Addison-Stavlo