jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

My Jetpack: AI detail table feature

Open CGastrell opened this issue 1 year ago • 2 comments

Rearrange of AI product pricing table. This PR serves as a feature branch, further project changes should merge onto this one.

DO NOT MERGE!

hzEFw0xtiYggqdai27aYN0-fi-4677_8829 p1HpG7-r6r-p2

Closes #35912 Closes #35838

Proposed changes:

This PR changes the output of the AI product class to render a pricing table properly. It also extends the navigation functionality within My Jetpack to allow for custom flow and a new product teaser page.

The feature relies on the filter to enable all the backend changes, frontend can handle both scenarios.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1HpG7-r6r-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

You need to add the filter to enable the new page, this is done on the instance, not on backend. Download and use Code Snippets plugin if you're not testing on local env:

add_filter( 'my_jetpack_use_new_ai_page', '__return_true' );

See the designs and the proposed changes to have a guide of what to expect. Visit My Jetpack page and use the AI card to see the pricing table. See that there's always 2 tiers: the upgrade option and the current one (be it free or not). Test both buttons (upgrade and remain on current).

Remaining free/on current tier should get you to the new product page.

Purchasing an upgrade should get you back at the product table, or to referrer if you came from, say, one of the upgrade buttons in the editor.

  • Verify event jetpack_myjetpack_product_interstitial_free_link_click has triggered after you opted to retain free/current.

CGastrell avatar Feb 23 '24 18:02 CGastrell

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for April 2, 2024 (scheduled code freeze on April 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Backup plugin:

  • Next scheduled release: April 2, 2024.
  • Scheduled code freeze: March 25, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Boost plugin:

  • Next scheduled release: April 2, 2024.
  • Scheduled code freeze: March 25, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Search plugin:

  • Next scheduled release: April 2, 2024.
  • Scheduled code freeze: March 25, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Social plugin:

  • Next scheduled release: April 2, 2024.
  • Scheduled code freeze: March 25, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Starter Plugin plugin:

  • Next scheduled release: April 2, 2024.
  • Scheduled code freeze: March 25, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Protect plugin:

  • Next scheduled release: April 2, 2024.
  • Scheduled code freeze: March 25, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Videopress plugin:

  • Next scheduled release: April 2, 2024.
  • Scheduled code freeze: March 25, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Migration plugin:

  • Next scheduled release: April 2, 2024.
  • Scheduled code freeze: March 25, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Feb 23 '24 18:02 github-actions[bot]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/my-jetpack-ai-detail-table branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/my-jetpack-ai-detail-table
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Feb 23 '24 18:02 github-actions[bot]