jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

Publicize: Make pre-publish panel initially closed

Open mashikag opened this issue 3 years ago • 3 comments

Fixes https://github.com/Automattic/wp-calypso/issues/68383

Changes proposed in this Pull Request:

  • make the Share this post section in the pre-publish panel initially closed

BEFORE Screen Shot 2022-09-28 at 18 09 13

AFTER Screen Shot 2022-09-28 at 18 13 58

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

pbAok1-3fI-p2

Does this pull request change what data or activity we track or use?

No, it does not.

Testing instructions:

  • Ensure you have the following jetpack settings on your site Screen Shot 2022-09-28 at 18 18 52

  • Go to new post editor

  • Write some post content

  • Press Publish

  • Pre-publish panels should have opened up in the editor's sidebar. One of them is Share this post. Ensure it is initially closed.

mashikag avatar Sep 28 '22 16:09 mashikag

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/publicize-close-pre-publish-panel to get started. More details: p9dueE-5Nn-p2

github-actions[bot] avatar Sep 28 '22 16:09 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: All commits were linted before commit.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: October 4, 2022.
  • Scheduled code freeze: September 27, 2022.

github-actions[bot] avatar Sep 28 '22 16:09 github-actions[bot]

I am reviewing this PR now.

ivan-ottinger avatar Sep 29 '22 08:09 ivan-ottinger