jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Fix/autoloader guard allows same plugin in mu plugins

Open darssen opened this issue 3 years ago • 1 comments

Changes proposed in this Pull Request:

  • Changed check in autoloader guard to consider the comparison between current and latest plugin to be done using plugin data instead of the plugin path. p1660675242364729-slack-CDD9LQRSN 3543-gh-Automattic/vip-go-mu-plugins

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ X ] Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Install the same version of a plugin that uses Jetpack autoloader (e.g. Jetpack) inside mu-plugins (This can be done by copying the plugin folder into the mu-plugins folder and using a proxy PHP loader file as indicated here )
  • Make sure the plugin is in active plugins.
  • Try to navigate to the WP application.
  • Prior to the changes, a Fatal Cannot declare class ... should appear. After the changes Fatal should not be present and application should be able to load normally.

darssen avatar Sep 13 '22 09:09 darssen

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: All commits were linted before commit.
  • :red_circle: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

github-actions[bot] avatar Sep 13 '22 09:09 github-actions[bot]