Automattic
Update/deprecate jetpack plan tiled gallery
Changes proposed in this Pull Request:
- Changed
Jetpack_PlanstoCurrent_Planfor tiled-gallery extenstion
Other changes connected to this: https://github.com/Automattic/jetpack/pull/25701 https://github.com/Automattic/jetpack/pull/25706
Jetpack product discussion
1202726932197503-as-1202726932197515 pdWQjU-4i-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
- Tiled-gallery should work as before
- Try adding and using tiled gallery in editor with and without having a plan
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
- :white_check_mark: Include a description of your PR changes.
- :white_check_mark: All commits were linted before commit.
- :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
- :white_check_mark: Add testing instructions.
- :white_check_mark: Specify whether this PR includes any changes to data or privacy.
- :white_check_mark: Add changelog entries to affected projects
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team review" label and ask someone from your team review the code. Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.
Jetpack plugin:
- Next scheduled release: September 6, 2022.
- Scheduled code freeze: August 30, 2022.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @jeherve! I needed a confidence check on testing extension files.
Is there anything special we need to keep in mind when testing extension files such as this one projects/plugins/jetpack/extensions/blocks/tiled-gallery/tiled-gallery.php or will the usual jetpack watch plugins/jetpack suffice? There seem to be some special instructions here for the block editor extensions, which I think I should be following.
will the usual jetpack watch plugins/jetpack suffice?
It should work just fine, yeah. It will build the plugin and the editor extensions included in the plugin, so you will see them in the block editor on your site.
