De-Fusion: Infinite Scroll

[sdixon194]

Impacted plugin

Jetpack

What

Infinite Scroll

How

"$plugin_root/modules/infinite-scroll/infinity-customizer.js"     => "$wpcom_root/wp-content/mu-plugins/infinity/infinity-customizer.js",
"$plugin_root/modules/infinite-scroll/infinity.php"               => "$wpcom_root/wp-content/mu-plugins/infinity/infinity.php",
"$plugin_root/modules/infinite-scroll/infinity.js"                => "$wpcom_root/wp-content/mu-plugins/infinity/infinity.js",
"$plugin_root/modules/infinite-scroll/infinity.css"               => "$wpcom_root/wp-content/mu-plugins/infinity/infinity.css",
"$plugin_root/modules/infinite-scroll/themes/twentyeleven.css"    => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyeleven.css",
"$plugin_root/modules/infinite-scroll/themes/twentyeleven.php"    => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyeleven.php",
"$plugin_root/modules/infinite-scroll/themes/twentyten.css"       => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyten.css",
"$plugin_root/modules/infinite-scroll/themes/twentyten.php"       => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyten.php",
"$plugin_root/modules/infinite-scroll/themes/twentytwelve.css"    => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentytwelve.css",
"$plugin_root/modules/infinite-scroll/themes/twentytwelve.php"    => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentytwelve.php",
"$plugin_root/modules/infinite-scroll/themes/twentythirteen.css"  => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentythirteen.css",
"$plugin_root/modules/infinite-scroll/themes/twentythirteen.php"  => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentythirteen.php",
"$plugin_root/modules/infinite-scroll/themes/twentyfourteen.css"  => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyfourteen.css",
"$plugin_root/modules/infinite-scroll/themes/twentyfourteen.php"  => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyfourteen.php",
"$plugin_root/modules/infinite-scroll/themes/twentyfifteen.php"   => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyfifteen.php",
"$plugin_root/modules/infinite-scroll/themes/twentyfifteen.css"   => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyfifteen.css",
"$plugin_root/modules/infinite-scroll/themes/twentysixteen.php"   => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentysixteen.php",
"$plugin_root/modules/infinite-scroll/themes/twentysixteen.css"   => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentysixteen.css",
"$plugin_root/modules/infinite-scroll/themes/twentyseventeen.php" => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyseventeen.php",
"$plugin_root/modules/infinite-scroll/themes/twentyseventeen.css" => "$wpcom_root/wp-content/mu-plugins/infinity/themes/pub/twentyseventeen.css",

[zinigor]

So I'm ashamed to admit that there's this huge diff that meant to bring IS back into Sync, but I haven't yet merged it: D15997-code

When you get to this, let me know, we can look at it together, because there were several gotchas.

[sdixon194]

@zinigor Glad I saw this comment before I started investigating which ones were in sync or not :D I'll mark this for later, but we'll likely be getting to it in the next 2-3 weeks or so just FYI.

[anomiex]

Looks like D43744-code took care of many of the same desyncs. All I see that's left are that wpcom missed https://github.com/Automattic/jetpack/pull/16129 and Jetpack missed D54641-code and D56493-code.

[anomiex]

#27065 and D90674-code will take care of those.

[sdixon194]

I believe this is waiting for the 11.6-a.1 release next week before we can land?

[anomiex]

We can do D90674-code now to bring things in sync, but the final de-Fusioning needs to wait for 11.6-a.1 to bring #27065 to wpcom.

[sdixon194]

Files now in sync, so this can be defusioned.

[sdixon194]

Igor's diff: D91710-code

[sdixon194]

Defusion deployed in r256375-wpcom

Two cleanup diffs:

removing a usage of a js file: D92652-code removing the files: D92648-code

[sdixon194]

Both cleanup diffs merged: r256414-wpcom

Defusioning is complete! 🎉