VIP-Coding-Standards icon indicating copy to clipboard operation
VIP-Coding-Standards copied to clipboard

Downgrade "HTML string concatenation detected" rule from an error to a warning

Open dartiss opened this issue 6 years ago • 1 comments

The full rule being triggered...

Error: HTML string concatenation detected, this is a security risk, use DOM node construction or a templating language instead: ''+ (WordPressVIPMinimum.JS.StringConcat.StringConcatNext).

This is causing a lot of false positives, where the solution has already been put into place but this error is still being reported. Could this be changed to a warning?

Discussed with @GaryJones

dartiss avatar Apr 24 '19 14:04 dartiss

Do you have some examples of false positives? Wether it's degraded or not we should spin up parallel tickets to try and reduce this!

tomjn avatar Apr 24 '19 18:04 tomjn