react-base-table icon indicating copy to clipboard operation
react-base-table copied to clipboard

Documentation improvement: styles.css requirement

Open robbienohra opened this issue 5 years ago • 4 comments

It should be made more clear in the documentation that the following import is required:

import 'react-base-table/styles.css'

I.e. that BaseTable will not render correctly without the above import.

It's not clear that BaseTable will not render correctly "out of the box" without the above style import.

robbienohra avatar Dec 11 '20 21:12 robbienohra

PR is welcome :p

nihgwu avatar Dec 15 '20 22:12 nihgwu

@nihgwu least I can do for the fabulous work you all have done with this library! I'll get on it 😉

robbienohra avatar Dec 15 '20 22:12 robbienohra

Done! Let me know if I should change the phrasing at all. 😊

robbienohra avatar Dec 15 '20 22:12 robbienohra

It's not really the styles.css file per se as much as it is the CSS classes defined in them, lol. So maybe it's better to phrase it to emphasize the classes themselves. Open to feedback!

robbienohra avatar Dec 15 '20 22:12 robbienohra