XLB icon indicating copy to clipboard operation
XLB copied to clipboard

Improved KBC performance

Open hsalehipour opened this issue 8 months ago • 1 comments

Contributing Guidelines

Description

The MLUPs performance of KBC has been improved by this simple combination of calls to the same function. mlups_3d.py with KBC + D3Q27 on A6000 gives:

  • Before this contribution, MLUPs: 2281.69
  • After this contribution: MLUPs: 3138.76

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update

How Has This Been Tested?

  • [x] All pytest tests pass

Linting and Code Formatting

Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.

To run Ruff, execute the following command from the root of the repository:

ruff check .
  • [x] Ruff passes

hsalehipour avatar May 13 '25 22:05 hsalehipour

Thanks.

  1. The parameters listed in the docstring should be delta_s, delta_h, feq, not x, y, feq.
  2. Line 96: "Entropic scalar product of X, Y, and feq." should describe that it returns two scalar products, sp1 and sp2, and briefly what they represent.
  3. Line 251: "Construct functional for computing entropic scalar product" should be "...entropic scalar products" (plural).

mehdiataei avatar May 20 '25 00:05 mehdiataei

Added the requested changes.

hsalehipour avatar May 21 '25 01:05 hsalehipour