Callback now made when error occurs during request execution.

Open kfdarlington opened this issue 7 years ago • 3 comments

If an error occurred while executing a request, the callback being passed into the execute function was not made. This PR adds that call and passes in the error and response to the callbacks as per Node.js standards: https://nodejs.org/api/errors.html#errors_error_first_callbacks.

Sep 11 '18 18:09 kfdarlington

@sunnyrajrathod Could you review this please?

Sep 11 '18 18:09 kfdarlington

@sunnyrajrathod pinging again

Sep 17 '18 23:09 kfdarlington

@kristian-d We are evaluating this PR and will get back to you soon.

Sep 18 '18 09:09 vijayabraj