Authenticator icon indicating copy to clipboard operation
Authenticator copied to clipboard
verified publisher icon Authenticator-Extension

Padding in window.

Open sophuric opened this issue 6 years ago • 7 comments

Describe the bug: There is padding in the window, this might be the scrollbar.

image

Also when I scroll down, the menubar goes, and there is even more of a gap at the bottom of the window.

image

Platform:

  • Browser: Chrome
  • Browser Version: 77.0.3865.90 (Official Build) (64-bit)

sophuric avatar Sep 26 '19 22:09 sophuric

Did you scale the popup page? You can find scale settings from menu->popup page->scale

Sneezry avatar Sep 27 '19 03:09 Sneezry

@Sneezry Yes, I have it at 125% which is the problem. So can you please fix it. At all the other scales this padding doesn't appear.

sophuric avatar Sep 27 '19 08:09 sophuric

We use CSS scale to scale the UI roughly. However, it worked really well in the past. I have no idea if it's a CSS bug on Chrome. I will try to fix this issue in the next a few days.

Sneezry avatar Oct 14 '19 16:10 Sneezry

Can I take a crack at this?

dhulwells avatar Oct 18 '19 02:10 dhulwells

@dhulwells go right ahead! Relevant file is sass/popup.scss

mymindstorm avatar Oct 18 '19 02:10 mymindstorm

and this function

https://github.com/Authenticator-Extension/Authenticator/blob/7b9d9527d29f01bb13e7758c1daa370081997d31/src/store/Menu.ts#L43-L49

mymindstorm avatar Oct 18 '19 02:10 mymindstorm

I've changed the select tag values and the gap starts to appear at 112%. Animation showing that the side padding appears at 112%

sophuric avatar Oct 18 '19 21:10 sophuric