Aung Ko Ko Lin (Quartile)
Aung Ko Ko Lin (Quartile)
@FreezeS Can you please review?
@mav-adhoc Can you please check why tests CI are failed?
@mav-adhoc I am wondering why you didn't migrate from 15.0 branch instead of 13.0. Is there any reason?
> Do you think it's really a good idea to combine the modules into one? I fail to see the point of doing so as the use cases are independent...
@pedrobaeza I have a concern. Is it a good design choice to keep all security functionalities related to purchase in the purchase_security module? If new purchase security features are proposed...
@HviorForgeFlow Can you please review this PR?
@aisopuro I noticed three points. - I think this module should only depends on `sale_stock` and `purchase_stock` because these are enough for the functionality of this module. - I tested...
@aisopuro > The method `sale.order.line:_purchase_service_prepare_line_values` is defined in `sale_purchase`, so I think we need to depend on that one. `sale_purchase` is `auto_install=True`. So, I think we don't need to depend...
@aisopuro Sorry for late reply. > I disagree that `auto_install=True` makes it so we don't need to depend on the module. We extend one of its methods, and call `super`...
@matt454357 There are some changes and commits that are not related to the PR. It seems like something went wrong during your rebase.