enchanted icon indicating copy to clipboard operation
enchanted copied to clipboard

Updates to Voice list in settings: removing duplicates, other languages

Open e28eta opened this issue 11 months ago • 0 comments

This might be a partial fix for #149. There are other ideas in that issue that I haven't looked at.

This PR does the following:

  • Add all of the voices that exactly match the current language & region
  • Add any voices that match the current language, from a different region, that aren't already in the list.
  • Filters out voices that are for other languages
  • Filters out duplicate entries
  • Only show voice "quality" if it's non-Default. Should be more clear what's happening.
  • This PR also uses the system default voice by default, and only uses the in-app voice list if the user has specifically chosen & saved a voice in Enchanted.

After:

Screenshot 2025-02-04 at 6 24 17 PM

Before (truncated Picker list, it's 3-4x longer):

Screenshot 2025-02-04 at 7 28 43 PM

Side note: in order to build & test, I had to do something with swift-markdown-ui. I didn't see #154 / #155 , but made a similar change locally.

e28eta avatar Feb 05 '25 03:02 e28eta