audius-protocol icon indicating copy to clipboard operation
audius-protocol copied to clipboard

pull ganache local/test containers and merge both audius-compose down operations

Open alecsavvy opened this issue 2 years ago • 5 comments

Description

  • removes the build option for eth-ganache and acdc-ganache in favor of pulling from docker hub
  • merges both down and test_down commands into one so devex when downing all containers is smoother

How Has This Been Tested?

audius-compose up shows images for eth-ganache and acdc-ganache being pulled instead of built audius-compose down also brings down test containers after running any test option ci should also be doing this exact flow

alecsavvy avatar Jan 24 '24 13:01 alecsavvy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
audius-web-ssr ⬜️ Ignored (Inspect) Jan 24, 2024 1:37pm

vercel[bot] avatar Jan 24 '24 13:01 vercel[bot]

I'm ready to rubber-stamp this, I just want to see the pulling in action (might have to rerun test-audius-cmd a couple times)

phelpsdb avatar Jan 25 '24 00:01 phelpsdb

There's some instability with the eth-ganache test job i want to look at as well, could be related to this PR

alecsavvy avatar Jan 27 '24 22:01 alecsavvy

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9368958 Triggered Generic Password ed3c15582d44e7b5ea8d54fe18cf96328173cb50 dev-tools/compose/docker-compose.ddex.yml View secret
9349019 Triggered Generic High Entropy Secret ed970b5b925930acc2823fc05ee25f68b8f0868a packages/ddex/.env.stage View secret
9412812 Triggered Generic Password ed970b5b925930acc2823fc05ee25f68b8f0868a packages/discovery-provider/ddl/local-test.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Feb 14 '24 22:02 gitguardian[bot]

upload is failing on this branch, unsure why

alecsavvy avatar Feb 14 '24 22:02 alecsavvy