audius-protocol icon indicating copy to clipboard operation
audius-protocol copied to clipboard

CON-505 Re-organize CN config

Open SidSethi opened this issue 3 years ago • 2 comments

Description

Nothing was removed, only re-ordered for easier management - pairs with https://github.com/AudiusProject/audius-docker-compose/pull/140

I confirmed each one by hand to make sure no config values were removed (can also sanity check by noticing there are more added lines than removed lines in this PR)

Tests

n/a

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

n/a

SidSethi avatar Nov 04 '22 15:11 SidSethi

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
3939057 Generic High Entropy Secret 4107fe733230b978c5f72b9772a50c3695ff4830 service-commands/src/utils/constants.js View secret
4714545 Generic High Entropy Secret 4107fe733230b978c5f72b9772a50c3695ff4830 service-commands/src/utils/constants.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Nov 04 '22 15:11 gitguardian[bot]

not worth - closing

SidSethi avatar Jan 20 '23 15:01 SidSethi