Hide application shortcut on macOS not working

Open diegolamanno opened this issue 4 years ago • 3 comments

Summary

Currently, when trying to use the command in macOS to hide the application doesn't work.

How to replicate

On macOS press cmd+h

Expected result

Applications hides from the screen. This is different from cmd+m (minimized)

Tested on

macOS Big Sur (11.5.2)
Audius Version 0.24.30

Sep 24 '21 18:09 diegolamanno

I was trying to fix it myself but I am not familiar with the app. I am NOT an expert on electron but I believe it should be something simple with sendActionToFirstResponder. If someone can provide some guidance I can try to put a PR ☺️

Sep 24 '21 18:09 diegolamanno

Hi @diegolamanno thank you for posting this! https://github.com/AudiusProject/audius-client/blob/master/src/electron.js#L282

All you should have to do is add an entry here. Looking forward to the PR :D

https://www.electronjs.org/docs/api/menu-item

Sep 28 '21 20:09 raymondjacobson

Hi @diegolamanno thank you for posting this! https://github.com/AudiusProject/audius-client/blob/master/src/electron.js#L282

All you should have to do is add an entry here. Looking forward to the PR :D

https://www.electronjs.org/docs/api/menu-item

Amazing. Thanks for the info. I will give it a shot this weekend 👍

Sep 29 '21 13:09 diegolamanno

Closed, repo is deprecated. We can continue discussion here: https://github.com/AudiusProject/audius-protocol/issues/5963

Sep 11 '23 21:09 sliptype