Deprecation of sklearn
Your https://github.com/AudioCommons/timbral_models/blob/master/setup.py depends on sklearn, which is now deprecated. The suggested fix is to use scikit-learn instead.
Does someone have the time to try this? For some reason I get an error when trying to clone the repository. The easiest way to try might be
- clone the repository
- change line 27 in https://github.com/AudioCommons/timbral_models/blob/master/setup.py
- in the terminal, go into the repository with
cd your/path/to/timbral_modelsand try to locally install usingpip install -e .(you might want to do this in a separate python environment)
@Rodsis, @AndyP103, @ffont pull request #17 does this , but it seems to do more than changing setup.py. Maybe a simple pull doing only this could be merged quickly to release a new version of timbral_models. I would consider this a bug and our students are currently having trouble using timbral_models at all.
@f-brinkmann I have created a focused pull request that addresses only the update from sklearn to scikit-learn in the setup.py file. This should ensure compatibility without the additional changes included in pull request #17