Potential Refactoring Estimate

[alvintanjianjia]

Summary I have identified a few classes with refactoring potential along with its estimated time to refactor, specifically AbstractJetty9AsyncSupportWithWebSocket.java. The estimated time is based on historical commits containing refactoring and the complexity of the involved classes. The class was refactored once on May 16, 2017 along with other classes in commit 9fd3d45c01b0c52d57ddfb6664eb6bb67c072410. Given the duration of the last refactoring, could it be possible to improve this class further? I am probably not qualified and experienced enough to point out the exact code needs to be refactored, given my limited knowledge of the project and codebase.

Urgency Low priority. For maintenance of code in the long run.

Hi, I am currently doing some research on Estimating Time Taken for Software Refactoring. Atmosphere is one of my case studies being a highly popular project. Would appreciate your kind feedback on the appropriateness of the estimated time to refactor. I am specifically looking at potential for refactoring, such as breaking functions that are too long into shorter functions, or to remove code duplication. Would you agree that there could be some modification to the code to make it better in the listed classes? And if so, is the estimated time appropriate to carry out the improvement? I will be grateful for any help you can provide.

1. AbstractJetty9AsyncSupportWithWebSocket.java - 2 hours
2. AbstractReflectorAtmosphereHandler.java - 2 hours
3. AbstractBroadcasterCache.java - 2.5 hours

Thank you.

Regards, Alvin

[jfarcand]

@alvintanjianjia You are welcome to do a pull request with your findings