ZeroOctave-Javascript-Projects icon indicating copy to clipboard operation
ZeroOctave-Javascript-Projects copied to clipboard

Changing the UI of height converter

Open Drishti-jain21 opened this issue 3 years ago • 4 comments

🛠️ Fixes Issue (Number) #887

👨‍💻 Changes proposed

I changed the background image, improved the UI of form and added text message when height is converted It even has a reset button, which was not there earlier. image

✅ Check List (Check all the applicable boxes)

  • [x] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
  • [x] This PR does not contain plagiarized content.
  • [x] My Addition/Changes works properly and matches the overall repo pattern.
  • [x] The title of my pull request is a short description of the requested changes.

Drishti-jain21 avatar Sep 25 '22 10:09 Drishti-jain21

Not working properly 1

Astrodevil avatar Sep 27 '22 09:09 Astrodevil

I'll check and revert back soon

Drishti-jain21 avatar Sep 27 '22 09:09 Drishti-jain21

It is working fine on my system, I just checked

Drishti-jain21 avatar Sep 27 '22 10:09 Drishti-jain21

image

image

image

Drishti-jain21 avatar Sep 27 '22 16:09 Drishti-jain21

I prefer the previous UI as it was simple and present image has no appropriate styling and doesn't really signifies anything. Still, I would merge the PR if the above changes are done.

Anmol-Baranwal avatar Feb 24 '23 08:02 Anmol-Baranwal

Thank you @Drishti-jain21 for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

github-actions[bot] avatar Mar 27 '23 19:03 github-actions[bot]