ZeroOctave-Javascript-Projects icon indicating copy to clipboard operation
ZeroOctave-Javascript-Projects copied to clipboard

Static Buttons on Drum Kit project [SSOC]

Open sumeetk10 opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe. In Drum Kit project, buttons are not clickable thus does not give any sound effect.

Describe the solution you'd like I would like to add clickable buttons upon clicking which a sound generates.

Describe alternatives you've considered It would be almost similar to piano buttons.

Additional context Screenshot 2022-08-17 204236

Steps Followed✅

Check the box with [x] If you followed all the steps.

  • [x] Is your feature request related to a problem? Please describe.
  • [x] Describe the solution you'd like
  • [x] Describe alternatives you've considered
  • [x] Additional context

Code of Conduct✅

sumeetk10 avatar Aug 17 '22 15:08 sumeetk10

Will you please provide the site link, not able to find this project on the site.

deeproop avatar Aug 17 '22 17:08 deeproop

https://zerooctave.github.io/ZeroOctave-Javascript-Projects/Public/drum_kit.html

sumeetk10 avatar Aug 18 '22 07:08 sumeetk10

Hello @sumeetk10, I have created a pull request for this issue, it will solve the problem in the drum kit project :)

deeproop avatar Aug 18 '22 09:08 deeproop

@Astrodevil kindly review the PR.

deeproop avatar Aug 18 '22 09:08 deeproop