AstroChart icon indicating copy to clipboard operation
AstroChart copied to clipboard

Add option to not make dash lines for houses

Open afucher opened this issue 2 years ago • 2 comments

Describe the bug The #25 PR introduce a breaking behavior, since it will draw the lines from the houses without consider the planets/points. In some configuration it makes harder to see the symbol with the line of the house behind it.

I'll revert the changes in the v2 and v3, but opening this issue to check how can we handle the wanted behavior from the #25 . Probably we can add a setting to the v3, to avoid make a dash line.

Screenshots See #25

afucher avatar Feb 21 '23 20:02 afucher

Hi @afucher, I still didn't get why it was a breaking behavior and how it could cause any issue. Could you show an example please?

ilyai avatar Feb 22 '23 18:02 ilyai

Sure @ilyai ! Changing the drawing order, makes the line of the houses be always drawn, and when it passes by a symbol it make it harder to see. And this could be worst in small devices, or when it cross the letter that indicates the dignities of the planet (like "r", "e", etc...) Adding an image from the doc that I'm creating, is not the worst case, but take a look to mercury Captura de Tela 2023-02-22 às 22 31 36

So, this should be an opt-in behavior, so the dev can turn it on or off.

afucher avatar Feb 23 '23 01:02 afucher