AsterNET icon indicating copy to clipboard operation
AsterNET copied to clipboard

Core show channels action and minor improvements

Open AlexAlexKud opened this issue 2 years ago • 3 comments

Better support CoreShowChannelsAction:

MAIN: AbstractChannelEvent now inherits ResponseEvent; CoreShowChannelsAction now inherits ManagerActionEvent; Added events CoreShowChannelEvent and ;CoreShowChannelsCompleteEvent;

BTW: Added support for TimeSpan and Guid properies in Parsing and ToString methods; Added AssemblyInfo attributes autogeneration ignore - this gives build an error in VS 2022

EXAMPLE: Now you can use CoreShowChannelsAction and receives its responses:

var action = new CoreShowChannelsAction();
var responses = manager.SendEventGeneratingAction(action);

AlexAlexKud avatar May 18 '23 16:05 AlexAlexKud

I can see that you changed indention from four spaces ( ) to taps ( ). This makes the diff kinda annoying to read. Any chance you could change that to spaces?

Of course, now that I think about there, there is a an option to hide whitespaces in the diff. image

But is is annoying to read the code on GitHub when the indention doesn't match.

Deantwo avatar May 21 '23 19:05 Deantwo

I can see that you changed indention from four spaces ( ) to taps ( ). This makes the diff kinda annoying to read. Any chance you could change that to spaces?

Fair remark! Fixed

AlexAlexKud avatar May 22 '23 07:05 AlexAlexKud

Comment to get attention @Deantwo @usender

AlexAlexKud avatar May 30 '23 09:05 AlexAlexKud