Bump versions for XCM `assets_reserve_transfer` precompile

Open 0x7CFE opened this issue 3 years ago • 2 comments

Recent frame-astar contains XCM precompile for assets_reserve_transfer.

This PR bumps collator and runtime versions and spec versions and updates xcm-primitives dependency.

Oct 11 '22 07:10 0x7CFE

 Compiling shiden-runtime v4.24.0 (/home/runner/work/Astar/Astar/runtime/shiden)
  error[E0046]: not all trait items implemented, missing: `ManagerOrigin`
     --> /home/runner/work/Astar/Astar/runtime/shiden/src/lib.rs:778:1
      |
  778 | impl pallet_xc_asset_config::Config for Runtime {
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `ManagerOrigin` in implementation
      |
      = help: implement the missing item: `type ManagerOrigin = Type;`

@Dinonard, looks your PR #754 is needed here :thinking: Maybe I am missing something? Is this the result of what you were saying about pallet-xc-asset-config?

Oct 11 '22 08:10 0x7CFE

@Dinonard, looks your PR #754 is needed here thinking Maybe I am missing something? Is this the result of what you were saying about pallet-xc-asset-config?

Yes, that's correct. ~~Fix~~Feature should be merged soon though.

In preparation, I'd suggest to change the PR so you exclude your Cargo.lock updates. That way you won't have to do a rebase since there will be no conflicts.

Oct 12 '22 12:10 Dinonard