add code for proposals and gateways,

Open bassjobsen opened this issue 7 years ago • 1 comments

used it with https://github.com/AschPlatform/asch-js/pull/21

Aug 26 '18 11:08 bassjobsen

@bassjobsen the review to your pull request:

Review

npm install doesn't work. Please change the package.json file to the following:

1

- "asch-js": "github:a1300/asch-js#fix_1_4_api",
+ "asch-js": "github:aschplatform/asch-js#develop",

2

You are using TABS in the README.md file. Please use only spaces:
review

3

On Line 387 in api.js there is a lonely keyword. I think it can be deleted. https://github.com/AschPlatform/asch-cli/blob/53e55172083ecc39ab78863e6f9299eeea13cd5e/plugins/api.js#L387

4

Please change the casing of all new functions in api.js that consist of more then two words: registergateway -> registerGateway

5

Please add a description to the <secret> for the command registermember because it must be the description of the member that wants to be registered and not a account that manages the registration for them :slightly_smiling_face:

Please change the small parts. Very good work! Thank you :+1:

Sep 17 '18 18:09 a1300