ROMP icon indicating copy to clipboard operation
ROMP copied to clipboard

wrong index when adjusting z-wise

Open 170928 opened this issue 3 years ago • 1 comments

In function ' coarse2fine_localization', for adjusting z-wise only, I think we use cam_maps_3d[:, :, :, :, 0], not [:, :, :, :, 2] because self.coordmap_3d is the result of concatenate (Z_map, Y_map, X_map).

        center_maps_3d = self.center_map_refiner(center_maps_3d.unsqueeze(1)).squeeze(1)
        cam_maps_3d = self.coordmap_3d + cam_maps_offset.unsqueeze(-1).transpose(4,1).contiguous()
        cam_maps_3d[:,:,:,:,2] = cam_maps_3d[:,:,:,:,2] + cam_maps_offset_bv.unsqueeze(2).contiguous()

170928 avatar Jul 26 '22 01:07 170928

Hi, MJ Shin @170928 Thanks a lot for pointing out this error! I will fix it in the next version.

Arthur151 avatar Jul 27 '22 13:07 Arthur151

@Arthur151 Is it already fixed? 🙂

vivi90 avatar Aug 17 '22 15:08 vivi90

Yes.

Arthur151 avatar Aug 27 '22 10:08 Arthur151