TwoFactorAuth icon indicating copy to clipboard operation
TwoFactorAuth copied to clipboard

Fixed a file system vulnerability

Open crackedeggs1 opened this issue 9 years ago • 0 comments

I noticed that some logins failed when auth.php did not submit over HTTPS. Some servers don't have it. TFA now works for sites with no SSL cert.

More importantly, I also noticed that while TFA_NGINX_DEBUG was enabled, it was possible for an attacker to fill the disk partition (using up all free space on the server) by flooding auth.php with requests. The debug.log is now limited to 100M in size. If it exceeds this size, it will be started over. There are definitely better ways to handle over-sized logs, such as rotating, but in the interest of closing the security hole, this is the most expedient solution.

crackedeggs1 avatar May 20 '16 15:05 crackedeggs1