python-adblock icon indicating copy to clipboard operation
python-adblock copied to clipboard

Certain selectors are not being returned by the engine.

Open alkim0 opened this issue 3 years ago • 2 comments

When running url_comsetic_resources, certain hide selectors are not being returned. For example, with ublock's filters.txt, on url_cosmetic_resources("https://google.com"), I would expect:

#atvcap > div:has(h3[role="heading"] > span:has-text(/^Ads/))

to be one of the hide selectors, but that is not returned. For url_cosmetic_resources("https://youtube.com"), I would expect:

ytd-display-ad-renderer:upward(ytd-rich-item-renderer)

to be one of the hide selectors, but that is not returned either.

alkim0 avatar Jul 13 '22 17:07 alkim0

Might be worth trying again now since I've updated the upstream library to 0.5.6.

ArniDagur avatar Jul 17 '22 23:07 ArniDagur

No go. This seems to a current limitation of the upstream library https://github.com/brave/adblock-rust/issues/145

alkim0 avatar Jul 25 '22 23:07 alkim0