feat: add ability for cardinal to read toml config file
Closes: WORLD-1129
Overview
Add ability for cardinal to read toml config file, the file can be read from :
- flag
--toml={filepath} - env var
CARDINAL_CONFIG - search
world.tomlfile in current dir & parrent dir
Brief Changelog
- Add func to read toml file in config.go and put it to env var
Testing and Verifying
- Added unit test
- Test manually using e2e package
Your org has enabled the Graphite merge queue for merging into main
Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai generate interesting stats about this repository and render them as a table. -
@coderabbitai show all the console.log statements in this repository. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @zulkhair and the rest of your teammates on
Graphite
Codecov Report
Attention: Patch coverage is 64.58333% with 17 lines in your changes are missing coverage. Please review.
Project coverage is 59.81%. Comparing base (
5d11880) to head (1f2ebe7).
Additional details and impacted files
@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 59.77% 59.81% +0.04%
==========================================
Files 142 142
Lines 7256 7302 +46
==========================================
+ Hits 4337 4368 +31
- Misses 2480 2488 +8
- Partials 439 446 +7
| Files | Coverage Δ | |
|---|---|---|
| cardinal/testutils/world.go | 82.44% <20.00%> (-2.48%) |
:arrow_down: |
| cardinal/config.go | 73.07% <69.76%> (+0.10%) |
:arrow_up: |
hmm, this looks kinda complicated. we should look into https://github.com/spf13/viper to abstract this for us
Updated using viper library
Merge activity
-
Jun 1, 3:58 AM EDT:
zulkhairadded this pull request to the Graphite merge queue. -
Jun 1, 4:03 AM EDT:
zulkhairmerged this pull request with the Graphite merge queue.