ArduRemoteID icon indicating copy to clipboard operation
ArduRemoteID copied to clipboard

pre arm checks: SN number add region parameter

Open BluemarkInnovations opened this issue 3 years ago • 4 comments

This PR adds:

  • region parameter: as each region has different mandatory fields/messages. For instance only in the EU the operator ID messages is mandatory. See https://github.com/opendroneid/opendroneid-core-c#comparison
  • performs basic checks whether the entered SN number meets the ANSI/CTA-2063-A standard
  • removes the mandatory requirement for the existence of SelfID messages
  • Although Japan is added as region, this is not fully compliant as it requires (support) for Auth messages too.
  • user can override these checks if https://github.com/ArduPilot/ArduRemoteID/pull/76 is merged and set by the user

BluemarkInnovations avatar Feb 03 '23 16:02 BluemarkInnovations

@friissoren @tridge @Davidsastresas

Do you have feedback regarding this improved pre-arm check?

In general there are three kind of checks:

  • ardupilot
    • will check if the RID module is alive and generate an error if this fails.
    • it will also set the status to emergency in case there is an emergency
  • the check_parse function, that checks for valid data.
    • It uses the encode functions of the opendroneID lib for that.
    • In this PR the serial number check is added.
    • And also a region parameter to allow different checks for different regions.
    • would it be useful to add a default valid SN? like ARDU8REM0TE1D The default ABCD123456789 is not accepted by the SN check.
  • the arm_status_check function.
    • this checks mostly if new data is still arriving i.e. the timestamp is updated.

There are other PRs that relate a bit to this: https://github.com/ArduPilot/ArduRemoteID/pull/102 and https://github.com/ArduPilot/ArduRemoteID/pull/103

BluemarkInnovations avatar Feb 07 '23 11:02 BluemarkInnovations

On QGC front I can accommodate it to whatever you guys do here and in Ardupilot. Just let me know what is necessary and I will include. Thanks!

Davidsastresas avatar Feb 07 '23 11:02 Davidsastresas

@BluemarkInnovations I've restructured this to be cleaner and easier to follow. Please check!

tridge avatar Oct 16 '23 02:10 tridge

@BluemarkInnovations any progress on this?

amilcarlucas avatar Jan 31 '24 16:01 amilcarlucas