zsync2 icon indicating copy to clipboard operation
zsync2 copied to clipboard

CMAKE_DEBUG_POSTFIX leaking from lib/cpr/opt/curl

Open conradjones opened this issue 5 years ago • 0 comments

If and only if you are using the embedded curl from cpr,

these lines leak

lib/zsync2/lib/cpr/opt/curl/tests/libtest/CMakeLists.txt:    PROPERTIES DEBUG_POSTFIX "${CMAKE_DEBUG_POSTFIX}")
lib/zsync2/lib/cpr/opt/curl/src/CMakeLists.txt:  DEBUG_POSTFIX "${CMAKE_DEBUG_POSTFIX}")
lib/zsync2/lib/cpr/opt/curl/CMakeLists.txt:set(CMAKE_DEBUG_POSTFIX "-d" CACHE STRING "Set debug library postfix")
lib/zsync2/lib/cpr/opt/curl/lib/CMakeLists.txt:       DEBUG_POSTFIX "-d"

and hashlib gets suffixed with -d

if you have system curl dev package installed these never get triggered and hashlib is not suffixed with -d

slightly separate point, but why is the lib prefix removed from hashlib ? It makes it tricky to link against.

conradjones avatar Mar 09 '20 06:03 conradjones