AppImageUpdate icon indicating copy to clipboard operation
AppImageUpdate copied to clipboard

We are lacking a .pc file for libappimageupdate

Open probonopd opened this issue 7 years ago • 4 comments

We are lacking a .pc file for libappimageupdate, needed for #91

probonopd avatar May 20 '18 22:05 probonopd

First of all, I highly doubt that a pkg-config file is needed for building an RPM file. But if you want to have one, feel free to provide me a suitable one, and I'll integrate it for you in the CMake configs.

TheAssassin avatar May 20 '18 22:05 TheAssassin

Currently we have to do

gcc -shared -o libgs_plugin_appimage.so gs-plugin-appimage.c -fPIC \
`pkg-config --libs --cflags gnome-software` -I/usr/include/appimage \
-lappimage -DI_KNOW_THE_GNOME_SOFTWARE_API_IS_SUBJECT_TO_CHANGE

A .pc file will allow us to do

gcc -shared -o libgs_plugin_appimage.so gs-plugin-appimage.c -fPIC \
`pkg-config --libs --cflags gnome-software appimage`  \
-DI_KNOW_THE_GNOME_SOFTWARE_API_IS_SUBJECT_TO_CHANGE

I need to read up on how to make one.

probonopd avatar May 21 '18 11:05 probonopd

-I/usr/include/appimage is not required. The correct include path for libappimage is #include <appimage/appimage.h>. I implemented this prefix path because of our other libraries. libappimageupdate can be used like <appimage/update.h>.

Also this issue sounded like the pkg-config file is required to build libappimageupdate in an RPM spec. However, the pkg-config file's purpose is for users of libappimageupdate. My comment needs to be interpreted with this assumption in mind. Please be more explicit about your reasons.

TheAssassin avatar May 21 '18 13:05 TheAssassin

Thanks for the hint. Will use <appimage/appimage.h>.

probonopd avatar May 21 '18 14:05 probonopd